fix: Move cursor position when using item movers #8510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't do the review, but all this sounds reasonable! |
|
Hmm, seems like there are still some rather annoying bugs in |
|
I sense a smell of broken glass here? |
|
I cannot for the life of me figure out how that typescript code works, but since the r-a part of these changes seems to be working fine, I guess we can land this. The cursor movement isn't really worse than it was before, at least. bors r+ |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the cursor position when moving items around to stay in the same location within the moved node.
I changed the
moveItemresponse toSnippetTextEdit[], since that made more sense to me (the file was ignored by the client anyways, since the edits always apply to the current document). It also matchesonEnter, which seems logical to me, but please let me know if this doesn't make sense.There's still a bug in the client-side snippet code that will cause the cursor position to be slightly off when moving parameters in the same line (presumably we don't track the column correctly after deleting
$0). Not really sure how to fix that immediately, but this PR should already be an improvement despite that bug.