fix: fix cursor position after item move command

[dbofmmbt]

Closes #8492

[dbofmmbt]

I started by trying to add tests for the cases I was referring to in #8492. It seems that the TextEdit generated by move_item is correct for the cases I added, but the cursor position was not in the right position when I tested on VS Code.

I'll continue looking to see if I can find the cause of the undesired offset.

[matklad]

Yeah, unclear why they are not picked up... The VS side of this is here:

• https://github.com/matklad/rust-analyzer/blob/0d319f296a8ce345a1dc0ec4ca8e9298a52eb605/editors/code/src/snippets.ts#L31-L62
• https://github.com/matklad/rust-analyzer/blob/0d319f296a8ce345a1dc0ec4ca8e9298a52eb605/editors/code/src/commands.ts#L137-L144

[dbofmmbt]

Thanks for the links! The problem is certainly on VS side. There's a off-by-one error in something involving startLine on snippets.ts:42. Maybe with lineDelta...

[dbofmmbt]

@matklad I think I found the issue. See the following line updating lineDelta:

https://github.com/eduardocanellas/rust-analyzer/blob/3bc69f362d8c173ce4748e7e853c0da5183e557a/editors/code/src/snippets.ts#L55

I think that it should increment lineDelta instead of overwritting its value. When I changed = to += the item movers seemed to work perfectly in the case I was checking. Looks reasonable?

It really feels good to have the item movers not moving the cursor around =D

[matklad]

bors r+

Thanks @eduardocanellas

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)

[lnicola]

changelog fix (first contribution) fix cursor position after move item command