fix: Code: use Uri.toString() for URLs

[wxb1ank]

I believe this should fix #9280. Testing is needed but I wanted to quickly push a hotfix.

Edit: Forgot to explain what the issue was. From my reply in #9280:

Looks like this is a regression from #8951. Specifically, in downloadFile() from /editors/code/src/net.ts, a vscode.Uri's .path property is mistakenly used as a URL (I think the .toString() method should work?). I don't immediately see any other sites where this is an issue.

Essentially, the .path property really only works for filesystem URIs, so URLs need to use a method that concatenates all URI components (this is what .toString() does). You can read about this here.

[lnicola]

This can't hurt, right?

bors r+

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)

[matklad]

We probably want to kick a nightly release

[matklad]

Did a release, also opened #9283.

Thanks @wxb1ank for lightning-fast fix by the way!

[wxb1ank]

Did a release, also opened #9283.

Thanks @wxb1ank for lightning-fast fix by the way!

No problem, sorry for the regression in the first place. I should've tested update functionality in #8951. Oh well :)

[SomeoneToIgnore]

@wxb1ank , maybe that helps you:

When changing the client, I was able to manually debug the functionality with the "Run Installed Extension" (see the screenshot).

To fully emulate various cases (weekly release tries to bootstrap, nightly release tries to bootstrap) you'll have to amend the package.json and put the proper version, releaseTag values and remove $generated-start, $generated-end ones.

Simplest way to "properly" adjust the package.json would be to download the corresponding rust-analyzer.vsix plugin from the r-a releases page, open it with any unarchiver, find the package.json there and copy-paste the contents over the one in the repo.
Then you start the debug and the plugin will pick up the amended package.json automatically, considering itself a weekly/nightly released plugin.

That should be enough to debug the bootstrap functionality on one platform of yours. I suggest testing at least two: Windows and Linux/Mac since the path handling is different in those which can lead to subtle bugs.

[wxb1ank]

@SomeoneToIgnore Thank you!! That makes testing much easier :)