fix: Code: clean-up #8951

[wxb1ank]

#8951 was a major change in the VS Code extension and caused quite a few problems. This PR is a catch-all for bugs and improvements in the new code.

This should fix:

• Cannot Update/Bootstrap rust-analyzer in Visual Studio Code #9284
• this unreported bug
• ...and one or two uncaught exceptions I just found

The original lack of testing was my own fault, but this area of the VS Code API is also tricky for a couple reasons:

• The FileSystem API does not list or warn about any exceptions, but FileSystemProvider (which FileSystem is a wrapper of, AFAICT) does.
• At first glance, Uri.path looks like it works for FS operations. It does not, at least, on Windows. You need to use Uri.fsPath.

I only use Windows, so I need people on macOS, Linux, and (possibly) NixOS to test this.

[lnicola]

/home/runner/work/rust-analyzer/rust-analyzer/editors/code/src/main.ts is not formatted

bors d+

[bors]

✌️ wxb1ank can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

[lnicola]

Looks fine, I guess? I can't test it right now, but I'm in favor of merging it optimistically. It can't make it worse than it is right now, can it?

[wxb1ank]

It can't make it worse than it is right now, can it?

I sure hope not :). I'll merge then.

bors r+

[bors]

Build succeeded:

• Rust (macos-latest)
• Rust (ubuntu-latest)
• Rust (windows-latest)
• TypeScript (ubuntu-latest)
• TypeScript (windows-latest)