feat: Implement goto_declaration support #9380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if goto_definition fallback logically belongs to the client? |
|
Another natural candidate here are trait methods. |
Good point, it feels like it could belong to the client.
Oh right, I was wondering if there was something else that has the notion of declaration vs definition in rust 👍 |
|
See #2541 for thoughts on this.
…On Tue, Jun 22, 2021, 8:04 PM Lukas Wirth ***@***.***> wrote:
I wonder if goto_definition fallback logically belongs to the client?
Good point, it feels like it could belong to the client.
Another natural candidate here are trait methods.
Oh right, I was wondering if there was something else that has the notion
of declaration vs definition in rust 👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9380 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBACRBZY6ROHBDM65ERGBTTUEQHRANCNFSM47EIM6XQ>
.
|
matklad
reviewed
Jun 23, 2021
crates/ide/src/goto_declaration.rs
Outdated
| _ => return None, | ||
| } | ||
| })(); | ||
| res.or_else(|| goto_definition::goto_definition(db, position)) |
There was a problem hiding this comment.
Let’s put this or_else in the handlers for now, otherwise, LGTM!
|
bors r=matklad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple implementation that falls back to
goto_definitionfor everything but modules where it goes to the actual module declaration if possible.