fix: Refactor & improve handling of overloaded binary operators #9988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#9971. Also records them as method resolutions, which we could use later.
flodiebold
changed the title
|
bors r+ |
lnicola
reviewed
Aug 23, 2021
| let lhs_diverges = self.diverges; | ||
| self.infer_expr_coerce(*rhs, &Expectation::HasType(bool_ty.clone())); | ||
| // Depending on the LHS' value, the RHS can never execute. | ||
| self.diverges = lhs_diverges; |
There was a problem hiding this comment.
Should this be self.diverges &= lhs_diverges;? For cases like true && loop {}.
There was a problem hiding this comment.
No, that would still only 'maybe' diverge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9971. Also records them as method resolutions, which we could use later.