size_t vs usize

[elichai]

Input C/C++ Header

#include <stddef.h>
static size_t A = 5;

bindgen converts size_t to `usize. but I'm not sure that's correct. the unsafe guidelines(https://rust-lang.github.io/unsafe-code-guidelines/layout/scalars.html) say that usize==uintptr_t. but the C standard doesn't define that uintptr_t==size_t therefore usize != size_t.

Am I missing something?

[highfive]

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

[emilio]

You're technically correct, I think (which is the best kind of correct ;)).

In practice, in all platforms that I know of sizeof(size_t) == sizeof(uintptr_t). See https://stackoverflow.com/questions/1464174/size-t-vs-uintptr-t.

But we should probably avoid doing this transformation, should be straight-forward.

[cmcavity]

Hi I'd like to work on this. Should the ssize_t to isize transformation be removed as well?
@highfive: assign me

[highfive]

Hey @cmcavity! Thanks for your interest in working on this issue. It's now assigned to you!

[cmcavity]

@emilio This issue should be closed after pull request #1688.

[emilio]

Fixed by the above PR.

[quidity]

For posterity, a flag was added to revert to previous behavior: --size_t-is-usize

f96dcf9