Skip to content

Bump quote to 0.5 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ clap = "2"
clang-sys = { version = "0.22.0", features = ["runtime", "clang_6_0"] }
lazy_static = "1"
peeking_take_while = "0.1.2"
quote = "0.3.15"
quote = { version = "0.5", default-features = false }
regex = "0.2"
which = "1.0.2"
proc-macro2 = { version = "0.3.2", default-features = false }

[dependencies.env_logger]
optional = true
Expand Down
48 changes: 20 additions & 28 deletions src/codegen/helpers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,28 @@ use ir::context::BindgenContext;
use ir::layout::Layout;
use quote;
use std::mem;
use proc_macro2::{Term, Span};

pub mod attributes {
use quote;
use proc_macro2::{Term, Span};

pub fn repr(which: &str) -> quote::Tokens {
let which = quote::Ident::new(which);
let which = Term::new(which, Span::call_site());
quote! {
#[repr( #which )]
}
}

pub fn repr_list(which_ones: &[&str]) -> quote::Tokens {
let which_ones = which_ones.iter().cloned().map(quote::Ident::new);
let which_ones = which_ones.iter().cloned().map(|one| Term::new(one, Span::call_site()));
quote! {
#[repr( #( #which_ones ),* )]
}
}

pub fn derives(which_ones: &[&str]) -> quote::Tokens {
let which_ones = which_ones.iter().cloned().map(quote::Ident::new);
let which_ones = which_ones.iter().cloned().map(|one| Term::new(one, Span::call_site()));
quote! {
#[derive( #( #which_ones ),* )]
}
Expand All @@ -40,9 +42,9 @@ pub mod attributes {
// time they get here. Just make sure that we have newlines around it so
// that nothing else gets wrapped into the comment.
let mut tokens = quote! {};
tokens.append("\n");
tokens.append(comment);
tokens.append("\n");
tokens.append(Term::new("\n", Span::call_site()));
tokens.append(Term::new(&comment, Span::call_site()));
tokens.append(Term::new("\n", Span::call_site()));
tokens
}

Expand Down Expand Up @@ -73,7 +75,7 @@ pub fn blob(layout: Layout) -> quote::Tokens {
}
};

let ty_name = quote::Ident::new(ty_name);
let ty_name = Term::new(ty_name, Span::call_site());

let data_len = opaque.array_size().unwrap_or(layout.size);

Expand Down Expand Up @@ -103,7 +105,7 @@ pub fn bitfield_unit(ctx: &BindgenContext, layout: Layout) -> quote::Tokens {
let mut tokens = quote! {};

if ctx.options().enable_cxx_namespaces {
tokens.append(quote! { root:: });
tokens.append_all(quote! { root:: });
}

let align = match layout.align {
Expand All @@ -114,7 +116,7 @@ pub fn bitfield_unit(ctx: &BindgenContext, layout: Layout) -> quote::Tokens {
};

let size = layout.size;
tokens.append(quote! {
tokens.append_all(quote! {
__BindgenBitfieldUnit<[u8; #size], #align>
});

Expand All @@ -126,6 +128,7 @@ pub mod ast_ty {
use ir::function::FunctionSig;
use ir::ty::FloatKind;
use quote;
use proc_macro2;

pub fn raw_type(ctx: &BindgenContext, name: &str) -> quote::Tokens {
let ident = ctx.rust_ident_raw(name);
Expand Down Expand Up @@ -166,29 +169,25 @@ pub mod ast_ty {

pub fn int_expr(val: i64) -> quote::Tokens {
// Don't use quote! { #val } because that adds the type suffix.
let mut tokens = quote! {};
tokens.append(val.to_string());
tokens
let val = proc_macro2::Literal::i64_unsuffixed(val);
quote!(#val)
}

pub fn uint_expr(val: u64) -> quote::Tokens {
// Don't use quote! { #val } because that adds the type suffix.
let mut tokens = quote! {};
tokens.append(val.to_string());
tokens
let val = proc_macro2::Literal::u64_unsuffixed(val);
quote!(#val)
}

pub fn byte_array_expr(bytes: &[u8]) -> quote::Tokens {
let mut bytes: Vec<_> = bytes.iter().cloned().collect();
bytes.push(0);
quote! {
#bytes
}
quote! { [ #(#bytes),* ] }
}

pub fn cstr_expr(mut string: String) -> quote::Tokens {
string.push('\0');
let b = quote::ByteStr(&string);
let b = proc_macro2::Literal::byte_string(&string.as_bytes());
quote! {
#b
}
Expand All @@ -199,16 +198,9 @@ pub mod ast_ty {
f: f64,
) -> Result<quote::Tokens, ()> {
if f.is_finite() {
let mut string = f.to_string();

// So it gets properly recognised as a floating point constant.
if !string.contains('.') {
string.push('.');
}
let val = proc_macro2::Literal::f64_unsuffixed(f);

let mut tokens = quote! {};
tokens.append(string);
return Ok(tokens);
return Ok(quote!(#val));
}

let prefix = ctx.trait_prefix();
Expand Down
3 changes: 2 additions & 1 deletion src/codegen/impl_partialeq.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ use ir::context::BindgenContext;
use ir::item::{IsOpaque, Item};
use ir::ty::{TypeKind, RUST_DERIVE_IN_ARRAY_LIMIT};
use quote;
use proc_macro2;

/// Generate a manual implementation of `PartialEq` trait for the
/// specified compound type.
Expand Down Expand Up @@ -71,7 +72,7 @@ pub fn gen_partialeq_impl(
}

fn gen_field(ctx: &BindgenContext, ty_item: &Item, name: &str) -> quote::Tokens {
fn quote_equals(name_ident: quote::Ident) -> quote::Tokens {
fn quote_equals(name_ident: proc_macro2::Term) -> quote::Tokens {
quote! { self.#name_ident == other.#name_ident }
}

Expand Down
Loading