-
Notifications
You must be signed in to change notification settings - Fork 746
Add generated_link_name_override
method for ParseCallbacks
.
#2425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tests aren't passing. Do you have any idea why? |
☔ The latest upstream changes (presumably a8c8638) made this pull request unmergeable. Please resolve the merge conflicts. |
it seems that bindgen doesn't output the same rust code for the cpp tests for every host platforms. I'm investigating. |
Got some update: it was failing because of the roundtrip test. |
☔ The latest upstream changes (presumably f019a9b) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably a101063) made this pull request unmergeable. Please resolve the merge conflicts. |
👋 hey I checked your PR and I was wondering if the |
hey! The idea behind prefixing the link name of every function and variables is to be able to link against a library that has been modified by |
`generated_link_name_override` lets the developer choose the link name for a symbol. If a link name is specified, the attribute `#[link_name = "\u{1}VALUE"]` will be set, overriding any other potential link name, including the mangled name. This commit also adds an option to the bindgen cli called `prefix-link-name`, to prefix the link name of exported symbols. I think this should properly solve #1375.
generated_link_name_override
lets the developer choose the link name fora symbol.
If a link name is specified, the attribute
#[link_name = "\u{1}VALUE"]
willbe set, overriding any other potential link name, including the mangled name.
This commit also adds an option to the bindgen cli called
prefix-link-name
,to prefix the link name of exported symbols.
I think this should properly solve #1375.