codegen: Don't implement variadic methods. #403
Conversation
| // Do not generate variadic methods, since rust does not allow | ||
| // implementing them, and we don't do a good job at it anyway. | ||
| if signature.is_variadic() { | ||
| return; |
There was a problem hiding this comment.
Might be worth a debug!(...) here.
| } | ||
| extern "C" { | ||
| #[link_name = "_ZN3Bar3fooEPKcz"] | ||
| pub fn Bar_foo(this: *mut Bar, fmt: *const ::std::os::raw::c_char, ...); |
There was a problem hiding this comment.
I think the point was supposed to be not to generate this, right?
First of all, we can't support variadics. Second of all, is this codegen'd a named type named ...? Need to implement the checks that named types are actually valid named types...
There was a problem hiding this comment.
Nope, the point was to not generate the wrapper method that calls this. Generating variadic functions otherwise is fine.
There was a problem hiding this comment.
(And nope, it's not a named type, rust's AST can represent variadic functions, which is what we use here)
There was a problem hiding this comment.
Hm yeah I guess the tests are passing which means it compiles. Color me surprised.
|
@bors-servo r+ |
|
📌 Commit b743ab0 has been approved by |
|
☀️ Test successful - status-travis |
Fixes #402
r? @fitzgen