Skip to content

Add example struct field init shorthand #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from Jun 8, 2017
Merged

Add example struct field init shorthand #837

merged 2 commits into from Jun 8, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2017

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ghost ghost mentioned this pull request Jan 16, 2017
5 tasks
@Havvy
Copy link
Contributor

Havvy commented Jan 16, 2017

Travis fails on stable and beta where field init shorthand syntax doesn't exist. It succeeds on nightly where it does. I'm presuming this patch will sit here until a release that has field init shorthand syntax in stable?

@steveklabnik
Copy link
Member

steveklabnik commented Jan 16, 2017

Yes. Thanks @HnGiang ! We're gonna have to wait though.

@steveklabnik
Copy link
Member

@hngnaig this syntax is now stable, can you remove the #![feature] stuff and then we can merge? Thanks!

@steveklabnik
Copy link
Member

I've made the change. Thanks!

@steveklabnik steveklabnik merged commit a0377dc into rust-lang:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants