-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesCategory: Enhancement of lints, like adding more cases or adding help messagesE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.
Description
We're duplicating a lot of the work Visitor does.
ExprUseVisitor might work, but there's no way of handling scopes.
cc @birkenfeld thoughts?
Metadata
Metadata
Assignees
Labels
C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesCategory: Enhancement of lints, like adding more cases or adding help messagesE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.Call for participation: Medium difficulty level problem and requires some initial experience.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
llogiq commentedon Sep 8, 2015
The ExprUseVisitor could at least work for the contains-check (though maybe it's even overkill for that).
llogiq commentedon Nov 10, 2015
#449 at least uses the Visitor for the contains check.
Auto merge of #7338 - camsteffen:shadow, r=llogic
Auto merge of #7338 - camsteffen:shadow, r=llogic