Skip to content

shadow lint should use visitor or ExprUseVisitor #318

@Manishearth

Description

@Manishearth
Member

We're duplicating a lot of the work Visitor does.

ExprUseVisitor might work, but there's no way of handling scopes.

cc @birkenfeld thoughts?

Activity

llogiq

llogiq commented on Sep 8, 2015

@llogiq
Contributor

The ExprUseVisitor could at least work for the contains-check (though maybe it's even overkill for that).

llogiq

llogiq commented on Nov 10, 2015

@llogiq
Contributor

#449 at least uses the Visitor for the contains check.

added
E-mediumCall for participation: Medium difficulty level problem and requires some initial experience.
C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messages
on May 10, 2017
added 2 commits that reference this issue on Sep 30, 2021
75167bb
f8303ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-enhancementCategory: Enhancement of lints, like adding more cases or adding help messagesE-mediumCall for participation: Medium difficulty level problem and requires some initial experience.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @oli-obk@Manishearth@llogiq

      Issue actions

        shadow lint should use visitor or ExprUseVisitor · Issue #318 · rust-lang/rust-clippy