Skip to content

lint emitting updating #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Aug 26, 2019 · 1 comment · Fixed by #4459
Closed

lint emitting updating #4456

ghost opened this issue Aug 26, 2019 · 1 comment · Fixed by #4459
Labels
A-documentation Area: Adding or improving documentation good first issue These issues are a good way to get started with Clippy

Comments

@ghost
Copy link

ghost commented Aug 26, 2019

if you don't run cargo uitest (and maybe cargo test) before tests/ui/update-all-references.sh the script won't do anything.

It would be nice if this could be made more clear. Got me really confused why cargo run and cargo build didn't trigger a change for the script.
@flip1995
Copy link
Member

https://github.com/rust-lang/rust-clippy/blob/master/doc/adding_lints.md#testing

This chapter would need to be updated. I think adding a note to the sentence mentioning the script would be enough.

@flip1995 flip1995 added good first issue These issues are a good way to get started with Clippy A-documentation Area: Adding or improving documentation labels Aug 26, 2019
@JohnTitor JohnTitor mentioned this issue Aug 27, 2019
Merged
bors added a commit that referenced this issue Aug 28, 2019
@bors
Auto merge of #4459 - JohnTitor:update-testing-notes, r=flip1995
f2d33c2 
Add note to avoid confusing

Fixes #4456

changelog: none
@bors bors closed this as completed in ad43d68 Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documentation Area: Adding or improving documentation good first issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note to avoid confusing JohnTitor/rust-clippy
1 participant
@flip1995