Should pick up panic!(format!(

[heca-project]

clippy should detect unnecessary format! blocks, such as panic!(format!( and others.

[blasrodri]

clippy should detect unnecessary format! blocks, such as panic!(format!( and others.

Can you be more specific in which cases this should be added? I guess you refer to some sort of short circuiting that makes some expression to remain unevaluated no matter what. Is that correct?

In particular, the case with panic! and format! does not follow those rules. For instance

#[derive(Debug)]
struct Whatever;

fn main() {
  let b = Whatever;
  panic!(format!("^^ {:?} ^^ ", b)) // prints ^^ Whatever ^^
}

[flip1995]

panic!(format!(..)) is always weird, since panic!() uses the same formatting syntax as fromat! and you could just remove the format! and it'll have the same output.

[flip1995]

This should also warn on other macros of the panic family unreachable/assert/...

[camsteffen]

Added in #7743