Skip to content

Allow many_single_char_names still produces warnings #5521

Closed
@bluss

Description

@bluss
Member

#![allow(clippy::many_single_char_names)] does not seem to suppress the lint, as it should,

It produces warnings like

warning: 6 bindings with single-character names in scope
   --> src\dimension\mod.rs:422:17
    |
422 | fn extended_gcd(a: isize, b: isize) -> (isize, (isize, isize)) {
    |                 ^         ^
...

Lints allowed in the code:

#![allow(
    clippy::many_single_char_names,
    clippy::deref_addrof,
    clippy::unreadable_literal,
    clippy::many_single_char_names
)]

Reproduced at ndarray commit 78bd1d84b9baf26c82c299e3bada43f72aa04614

Clippy version clippy 0.0.212 (6651c1b 2020-04-15)

CI log with failure (clippy at the end) https://travis-ci.org/github/rust-ndarray/ndarray/jobs/678756560

Previous similar issue #3198

Activity

flip1995

flip1995 commented on Apr 24, 2020

@flip1995
Member

This will be fixed with #5518

bluss

bluss commented on Apr 24, 2020

@bluss
MemberAuthor

nice!

added a commit that references this issue on Apr 25, 2020

Rollup merge of rust-lang#5518 - flip1995:less_pre_expansion, r=phansch

c532d66
added a commit that references this issue on May 26, 2020

Auto merge of #5651 - ebroto:names_as_early_passes, r=flip1995

fca76de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @bluss@flip1995

      Issue actions

        Allow many_single_char_names still produces warnings · Issue #5521 · rust-lang/rust-clippy