Skip to content

Write a "Clippy book"? #6011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manishearth opened this issue Sep 6, 2020 · 6 comments
Closed

Write a "Clippy book"? #6011

Manishearth opened this issue Sep 6, 2020 · 6 comments
Labels
A-documentation Area: Adding or improving documentation A-infra Area: CI issues and issues that require full access for GitHub/CI E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@Manishearth
Copy link
Member

Rustdoc has a really nice short book with a lot of the features explained: https://doc.rust-lang.org/rustdoc/

Perhaps we should do the same thing? We coudl then link it from the Rust website and might have fewer discoverability problems.

cc @rust-lang/clippy

@phansch
Copy link
Member

phansch commented Sep 7, 2020

Seems like a good idea - We could even go as far as including the lint documentation in the book. If the book is then bundled with rustup, like the other books, the lint docs would be available offline as well.

@phansch phansch added the A-documentation Area: Adding or improving documentation label Sep 7, 2020
@ebroto
Copy link
Member

ebroto commented Sep 7, 2020

I'm on board. I think we could also integrate the documentation about hacking on Clippy, maybe in a different book?

I'm not familiar with creating those books, but I guess we will need a test in CI to check that the book is generated correctly, so I'll add the infrastructure tag.

@ebroto ebroto added the A-infra Area: CI issues and issues that require full access for GitHub/CI label Sep 7, 2020
@flip1995
Copy link
Member

flip1995 commented Sep 7, 2020

I think we could also integrate the documentation about hacking on Clippy, maybe in a different book?

This should definitely be in a different book (clippy-dev-guide?). But since we already have the doc folder for this, this is lower prio.

Regarding infra: we kind of already have this in the remark check, but we need to add a CD pipeline to it (extending the deploy script?).

@phansch phansch added the E-help-wanted Call for participation: Help is requested to fix this issue. label Dec 18, 2020
@moaz-mokhtar
Copy link

Hello all,

I'm ready for that. Guide me to getting started.

@flip1995
Copy link
Member

The first step would be to set up mdbook in the Clippy repo and on CI. After that, the README should be transferred to the book.

@joshrotenberg
Copy link
Contributor

It looks like maybe the previous effort on this has stalled. I took a fresh crack at an outline with some lifted content and a big lists of questions on how to proceed: #7359

bors added a commit that referenced this issue Jun 6, 2022
Clippy book

A work in progress Clippy Book using mdbook. See #6011.

This is currently just a moving around of things:

1. The current README.md split up a bit and put into sections.
1. A rough outline of Clippy lint categories (currently no content, potentially add a basic introduction for each and some example, see questions below.
1. The `docs` content repurposed into a top level `Development` section.
1. The current Roadmap.

Some big questions:

1. is `guide/` the right place? I'm modeling after mdbook itself.
1. What is the relationship between ALL the Clippy Lints and this guide? It seems like they can coexist. Does that mean the guide should just point to the current side with regard to actual lints, and maybe just include some examples to keep it interesting? Keeping both up to date seems like a maintenance nightmare unless its automated somehow. Or should the current ALL the Clippy lints somehow be incorporated into the book?
1. Related to the above, where should this guide be published since the `gh-pages` branch is already in use?
1. This PR doesn't currently change any existing content. Obviously that would make sense assuming the general structure and relocation is an acceptable approach.

---

Open Tasks for follow up PR:
- Set up CI/CD
- Split up Installation and Usage
- Add more content to Usage (and Installation) chapters
- Enhance CI chapter with more examples for different CIs
bors added a commit that referenced this issue Jun 6, 2022
Clippy book

A work in progress Clippy Book using mdbook. See #6011.

This is currently just a moving around of things:

1. The current README.md split up a bit and put into sections.
1. A rough outline of Clippy lint categories (currently no content, potentially add a basic introduction for each and some example, see questions below.
1. The `docs` content repurposed into a top level `Development` section.
1. The current Roadmap.

Some big questions:

1. is `guide/` the right place? I'm modeling after mdbook itself.
1. What is the relationship between ALL the Clippy Lints and this guide? It seems like they can coexist. Does that mean the guide should just point to the current side with regard to actual lints, and maybe just include some examples to keep it interesting? Keeping both up to date seems like a maintenance nightmare unless its automated somehow. Or should the current ALL the Clippy lints somehow be incorporated into the book?
1. Related to the above, where should this guide be published since the `gh-pages` branch is already in use?
1. This PR doesn't currently change any existing content. Obviously that would make sense assuming the general structure and relocation is an acceptable approach.

---

Open Tasks for follow up PR:
- Set up CI/CD
- Split up Installation and Usage
- Add more content to Usage (and Installation) chapters
- Enhance CI chapter with more examples for different CIs

---

changelog: The first version of the *Clippy Book*
staring, *The Clippy Team*, *Bors* and *rustc*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Adding or improving documentation A-infra Area: CI issues and issues that require full access for GitHub/CI E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Development

No branches or pull requests

8 participants
@joshrotenberg @ebroto @Manishearth @Alexendoo @phansch @moaz-mokhtar @flip1995 and others