Skip to content

Prefer X.floor() instead of FP::floor(x) #9789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leonardo-m opened this issue Nov 4, 2022 · 1 comment
Open

Prefer X.floor() instead of FP::floor(x) #9789

leonardo-m opened this issue Nov 4, 2022 · 1 comment
Labels
A-lint Area: New lints

Comments

@leonardo-m
Copy link

leonardo-m commented Nov 4, 2022 •
edited by rustbot
Loading

What it does

Suggests a better pattern of code.

Lint Name

direct_method_call

Category

pedantic

Advantage

More dry, shorter.

Drawbacks

No response

Example

A pattern I've seen in code:

let y = f64::floor(x as f64);

I think it's better written:

let y = (x as f64).floor();
@leonardo-m leonardo-m added the A-lint Area: New lints label Nov 4, 2022
@blyxyas
Copy link
Member

blyxyas commented Nov 17, 2022

@rustbot claim

@blyxyas blyxyas mentioned this issue Nov 24, 2022
Closed
6 tasks
@blyxyas blyxyas removed their assignment Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Draft] Add direct_method_call lint
2 participants
@leonardo-m @blyxyas