improve manual_is_ascii_check check

[naosense]

Sorry, not familiar the api, i can only check the method name of expression <expr-1>.contains(<expr-2>) after read clippy book and hints from #9933 . i dont know how to check

1. if is a specific range
2. is a character

r? @xFrednet could you please provide some more hints? 😝️

---

changelog: Enhancement: [manual_is_ascii_check]: Now detects ranges with .contains() calls
#10053

[rustbot]

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

[llogiq]

1. We have a clippy_utils::higher::Range::hir(&Expr) call that will give you a higher::Range { start, end, limits } you can use to match both exclusive and inclusive ranges.
2. you'll be looking at a ExprKind::Lit with a node of LitKind::Char(c) containing the character.

[naosense]

@llogiq Can you take a look at whether I'm in the right direction?

[xFrednet]

This looks like a good start. The main thing missing are tests. I've added comments at the related locations :)

[xFrednet]

The implementation looks good to me, three more nits and then it's ready for merge. Would you mind squashing your commits a bit? Like the two ones adding tests and the two first ones with the same message. :)

[xFrednet]

Looks good to me, thank you for the addition. I hope you had fun :)

@bors r+

[bors]

📌 Commit 1f862c2 has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit 1f862c2 with merge be15e60...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing be15e60 to master...