Skip to content

Conversation

chansuke
Copy link
Contributor

@chansuke chansuke commented Dec 11, 2022

Add slight modification on this PR.


changelog: New lint [permissions_set_readonly_false]
#10063

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2022

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 11, 2022
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for taking this over

@chansuke chansuke requested a review from Alexendoo December 17, 2022 12:14
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry spotted a couple more things, that'll be it this time though I swear 😄

@bors
Copy link
Contributor

bors commented Dec 19, 2022

☔ The latest upstream changes (presumably #10099) made this pull request unmergeable. Please resolve the merge conflicts.

@chansuke chansuke force-pushed the issue-9702 branch 2 times, most recently from 2ac0463 to 6fd0329 Compare December 19, 2022 16:11
@chansuke chansuke requested a review from Alexendoo December 19, 2022 16:23
@Alexendoo
Copy link
Member

Great! Thanks again

@bors r+

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit b21cc36 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 20, 2022

⌛ Testing commit b21cc36 with merge 4a09068...

@bors
Copy link
Contributor

bors commented Dec 20, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 4a09068 to master...

@bors bors merged commit 4a09068 into rust-lang:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants