Include async functions in the len_without_is_empty #10359
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -282,6 +282,87 @@ impl AsyncLen { | |
| } | ||
| } | ||
|
|
||
| // issue #7232 | ||
| pub struct AsyncLenWithoutIsEmpty; | ||
| impl AsyncLenWithoutIsEmpty { | ||
| pub async fn async_task(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| pub async fn len(&self) -> usize { | ||
| usize::from(!self.async_task().await) | ||
| } | ||
| } | ||
|
|
||
| // issue #7232 | ||
| pub struct AsyncOptionLenWithoutIsEmpty; | ||
| impl AsyncOptionLenWithoutIsEmpty { | ||
| async fn async_task(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| pub async fn len(&self) -> Option<usize> { | ||
| None | ||
| } | ||
| } | ||
|
|
||
| // issue #7232 | ||
| pub struct AsyncOptionLenNonIntegral; | ||
| impl AsyncOptionLenNonIntegral { | ||
| // don't lint | ||
| pub async fn len(&self) -> Option<String> { | ||
| None | ||
| } | ||
| } | ||
|
|
||
| // issue #7232 | ||
| pub struct AsyncResultLenWithoutIsEmpty; | ||
| impl AsyncResultLenWithoutIsEmpty { | ||
| async fn async_task(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| pub async fn len(&self) -> Result<usize, ()> { | ||
| Err(()) | ||
| } | ||
| } | ||
|
|
||
| // issue #7232 | ||
| pub struct AsyncOptionLen; | ||
| impl AsyncOptionLen { | ||
| async fn async_task(&self) -> bool { | ||
| true | ||
| } | ||
|
|
||
| pub async fn len(&self) -> Result<usize, ()> { | ||
| Err(()) | ||
| } | ||
|
|
||
| pub async fn is_empty(&self) -> bool { | ||
| true | ||
| } | ||
| } | ||
|
|
||
| pub struct AsyncLenSyncIsEmpty; | ||
| impl AsyncLenSyncIsEmpty { | ||
| pub async fn len(&self) -> u32 { | ||
| 0 | ||
| } | ||
|
|
||
| pub fn is_empty(&self) -> bool { | ||
| true | ||
| } | ||
| } | ||
|
|
||
| // issue #9520 | ||
| pub struct NonStandardLen; | ||
| impl NonStandardLen { | ||
| // don't lint | ||
| pub fn len(&self, something: usize) -> usize { | ||
| something | ||
| } | ||
| } | ||
|
|
||
| // issue #9520 | ||
| pub struct NonStandardLenAndIsEmptySignature; | ||
| impl NonStandardLenAndIsEmptySignature { | ||
|
|
@@ -328,4 +409,15 @@ impl NonStandardSignatureWithGenerics { | |
| } | ||
| } | ||
|
|
||
| pub struct DifferingErrors; | ||
| impl DifferingErrors { | ||
| pub fn len(&self) -> Result<usize, u8> { | ||
| Ok(0) | ||
| } | ||
|
|
||
| pub fn is_empty(&self) -> Result<bool, u16> { | ||
| Ok(true) | ||
| } | ||
| } | ||
|
|
||
| fn main() {} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,5 +119,23 @@ LL | pub fn len(&self) -> Result<usize, ()> { | |
| | | ||
| = help: use a custom `Error` type instead | ||
|
|
||
| error: struct `AsyncLenWithoutIsEmpty` has a public `len` method, but no `is_empty` method | ||
| --> $DIR/len_without_is_empty.rs:292:5 | ||
| | | ||
| LL | pub async fn len(&self) -> usize { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: struct `AsyncOptionLenWithoutIsEmpty` has a public `len` method, but no `is_empty` method | ||
| --> $DIR/len_without_is_empty.rs:304:5 | ||
| | | ||
| LL | pub async fn len(&self) -> Option<usize> { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: struct `AsyncResultLenWithoutIsEmpty` has a public `len` method, but no `is_empty` method | ||
| --> $DIR/len_without_is_empty.rs:325:5 | ||
| | | ||
| LL | pub async fn len(&self) -> Result<usize, ()> { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: aborting due to 15 previous errors | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use of the
if is_first_generic_integral(segment)above if it returns the same thing anyway?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is a bug.
is_first_generic_integralchecks thatlen()returnsOption<T>where T is an integral type. This should ignore things likepub fn len() -> Option<String>because that's what happens for the sync version.I've added a test for this.