(Small) Fix broken links for Rust merge #10604
Conversation
rustbot
added
the
S-waiting-on-review
blyxyas
force-pushed
the
fix-book_broken_links
branch
from
2b51777 to
cf260bc
Compare
|
Thanks, this fixes the issue. Let's merge it here and I'll re-do the sync including this commit. @bors r+ p=1 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
| [CI]: continuous_integration/index.md | ||
| [CI]: continuous_integration/README.md |
There was a problem hiding this comment.
Looks like this change caused a new issue: rust-lang/rust#110003 (comment)
There was a problem hiding this comment.
I have no idea how to fix it then.
index.html didn't work (even though it's the URL from the book leading to that section), and README.md also doesn't work, even though it appears like that on SUMMARY.md. What more could it be?
Even then, all link's were checked with the mdbook-linkcheck crate before committing them. Could this be a bug in CI?
There was a problem hiding this comment.
I'm also out of ideas what could cause this. I'll make sure that we're using the same mdbook version in Clippy as in the Rust repo. Maybe some version difference broke something?
There was a problem hiding this comment.
I think I had the same issue before, when I finalized the first version of the book. Links to README.mds inside the book are a bit weird...
rust-lang/rust#110003's CI is currently broken because of broken links. This PR fixes that.
It was tested against
lintcheckand found another broken link inusage.md(apart from CI's broken links)changelog:Fix broken links in the book
Sorry for putting more work on you, but you're the one doing the Rust PR
r? @flip1995