[arithmetic_side_effects] Cache symbols #10675
Conversation
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Good catch! @bors r+ |
[arithmetic_side_effects] Cache symbols An internal-only modification to speed up the processing of symbols because "intern" isn't very cheap, even more when you are doing the same thing for every method expression.
|
💔 Test failed - checks-action_test |
|
Ah, we missed the changelog line. @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Isn't it simpler to add that strings to symbol table, and then just filter on symbols, skipping str<->String comparison/conversions? |
|
That is what I asked at #10615 (comment) IIRC, it is not rare to see PRs in |
An internal-only modification to speed up the processing of symbols because "intern" isn't very cheap, even more when you are doing the same thing for every method expression.
changelog: none