Skip to content

Improve the help message + add a help span #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 23, 2023

This would close #10410, because it applies the general consensus achieved in that issue (that replacing let _ = ... to _ = ... doesn't present any benefits).

I also added a little help message span.

changelog:[let_underscore_untyped]: Fix the help message confusion + add a help message span.

@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 23, 2023
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit acf50a7 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 24, 2023

⌛ Testing commit acf50a7 with merge c4f2c48...

@bors
Copy link
Contributor

bors commented Apr 24, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing c4f2c48 to master...

@bors bors merged commit c4f2c48 into rust-lang:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

let_underscore_untyped fails to consider configured msrv
4 participants