Skip to content

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 2, 2023

I use lint_reasons and clap, which is a bit overzealous when it comes to preventing warnings in its macros; it uses a ton of allow attributes on everything to, as ironic as it is, silence warnings. These two now ignore anything from procedural macros.

PS, I think allow_attributes.rs should be merged with attrs.rs in the future.

fixes #10377

changelog: [allow_attributes, allow_attributes_without_reason]: Ignore attributes from procedural macros

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 2, 2023
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jun 5, 2023

📌 Commit b469e8c has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 5, 2023

⌛ Testing commit b469e8c with merge 1841661...

@bors
Copy link
Contributor

bors commented Jun 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 1841661 to master...

@bors bors merged commit 1841661 into rust-lang:master Jun 5, 2023
@Centri3 Centri3 deleted the allow_attributes branch June 5, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP for allow_attributes_without_reason with ? operator
4 participants