Don't linting as_conversions in proc macros
#10911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
lochetti
changed the title
as_conversions in proc macrosas_conversions in proc macros
Alexendoo
approved these changes
Jun 12, 2023
|
Thanks! Yeah a late pass sounds like the best way to do it @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't linting
as_conversionsif code was generated by procedural macro.This PR fixes #9657
I implemented the fix changing the lint code to be a
LateLintPassin order to be able to use theis_from_proc_macroout of the box. If the reviwer thinks that it would be better to do the other way (implementingWithSearchPat) just let me know. I might need some help in implementing it for theustc_ast::ast::Exprchangelog: [
as_conversions] avoiding warnings in macro-generated code