[needless_pass_by_ref_mut]: Do not lint if passed as a fn-like argument
#11207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Centri3
changed the title
&mut closureneedless_pass_by_ref_mut]: Do not lint if passed as a fn-like argument
Centri3
force-pushed
the
#11182
branch
2 times, most recently
from
929e266 to
3a3961a
Compare
|
I think this fix would still lint incorrectly on my provided example in one of the linked issues: #11199 (comment) |
|
Yeah and I believe it'll still lint stuff like fn then(a: &mut u32) {}
fn els(a: &mut u32) {
*a = 2;
}
if true {
then
} else {
els
}Which isn't good |
|
☔ The latest upstream changes (presumably #11184) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
approved these changes
Jul 23, 2023
|
Looks good to me, great work! |
giraffate
approved these changes
Jul 25, 2023
|
@bors r+ Thanks! |
bors
added a commit
that referenced
this pull request
Jul 25, 2023
[`needless_pass_by_ref_mut`]: Do not lint if passed as a fn-like argument Fixes #11182 and also fixes #11199 (though this is kind of a duplicate) There's likely a case or two I've missed, so this likely needs a bit more work but it seems to work fine with the tests I've added. PS, the diff for the test is useless because it iterates over a hashmap before linting. Seems to work fine but we could maybe change this for consistency's sake changelog: [`needless_pass_by_ref_mut`]: No longer lints if the function is passed as a fn-like argument
|
💔 Test failed - checks-action_test |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11182 and also fixes #11199 (though this is kind of a duplicate)
There's likely a case or two I've missed, so this likely needs a bit more work but it seems to work fine with the tests I've added.
PS, the diff for the test is useless because it iterates over a hashmap before linting. Seems to work fine but we could maybe change this for consistency's sake
changelog: [
needless_pass_by_ref_mut]: No longer lints if the function is passed as a fn-like argument