Skip to content

Conversation

y21
Copy link
Member

@y21 y21 commented Oct 7, 2023

Fixes #11635

changelog: [into_iter_without_iter]: walk up deref impl chain to find iter methods

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 7, 2023
@llogiq
Copy link
Contributor

llogiq commented Oct 7, 2023

That looks entirely sensible. Thanks for fixing this bug.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2023

📌 Commit 1c6fa29 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 7, 2023

⌛ Testing commit 1c6fa29 with merge 7624045...

@bors
Copy link
Contributor

bors commented Oct 7, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 7624045 to master...

@bors bors merged commit 7624045 into rust-lang:master Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

into_iter_without_iter false positive when there is a Deref impl
4 participants