Skip to content

fix suggestion for [len_zero] with macros #11996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

fix suggestion for [len_zero] with macros #11996

merged 1 commit into from
Apr 1, 2024

Conversation

J-ZhengLi
Copy link
Member

fixes: #11992

changelog: fix suggestion for [len_zero] with macros

@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 22, 2023
J-ZhengLi
J-ZhengLi commented Dec 22, 2023
View reviewed changes
@J-ZhengLi
Copy link
Member Author

Manishearth says they are currently inactive?

r? @rust-lang/clippy

@rustbot rustbot assigned matthiaskrgr and unassigned Manishearth Dec 22, 2023
@Manishearth
Copy link
Member

Yeah I'm just busy for the next few weeks. Still reviewing but better to get someone else to do it.

@xFrednet
Copy link
Member

xFrednet commented Apr 1, 2024

@ARandomDev99 could you take a look at this one?

If you comment something on the PR, I can also add you as an assignee :D

r? xFrednet (I will regret taking so many PRs on...)

@rustbot rustbot assigned xFrednet and unassigned matthiaskrgr Apr 1, 2024
@ARandomDev99
Copy link
Contributor

Everything looks good to me. 👍

@xFrednet
Copy link
Member

xFrednet commented Apr 1, 2024

This version looks good to me, thank you!

@bors r=xFrednet,ARandomDev99

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit 2bdd5f0 has been approved by xFrednet,ARandomDev99

It is now in the queue for this repository.

bors added a commit that referenced this pull request Apr 1, 2024
@bors
Auto merge of #11996 - J-ZhengLi:issue11992, r=xFrednet,ARandomDev99
389592e 
fix suggestion for [`len_zero`] with macros

fixes: #11992

changelog: fix suggestion for [`len_zero`] with macros
@bors
Copy link
Contributor

bors commented Apr 1, 2024

⌛ Testing commit 2bdd5f0 with merge 389592e...

@bors
Copy link
Contributor

bors commented Apr 1, 2024

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Apr 1, 2024

Ahh, @J-ZhengLi could you rebase on master? The uitests need to be reblessed. Afterwards you can approve it in our names again :D

@bors delegate+

@bors
Copy link
Contributor

bors commented Apr 1, 2024

✌️ @J-ZhengLi, you can now approve this pull request!

If @xFrednet told you to "r=me" after making some further change, please make that change, then do @bors r=@xFrednet

@J-ZhengLi
Copy link
Member Author

Ahh, @J-ZhengLi could you rebase on master? The uitests need to be reblessed. Afterwards you can approve it in our names again :D

Sure, give me one sec~

@J-ZhengLi
Copy link
Member Author

Done~ @bors r=xFrednet,ARandomDev99

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit b456ed3 has been approved by xFrednet,ARandomDev99

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 1, 2024

⌛ Testing commit b456ed3 with merge 2b30a59...

@bors
Copy link
Contributor

bors commented Apr 1, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet,ARandomDev99
Pushing 2b30a59 to master...

@bors bors merged commit 2b30a59 into rust-lang:master Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xFrednet xFrednet xFrednet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@xFrednet xFrednet

@ARandomDev99 ARandomDev99

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[len_zero] suggestion causing compilation fail when macros involved
7 participants
@J-ZhengLi @rustbot @Manishearth @xFrednet @ARandomDev99 @bors @matthiaskrgr