Skip to content

Fix ICE introduced in #12004 #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix ICE introduced in #12004 #12064

wants to merge 1 commit into from

Conversation

PartiallyUntyped
Copy link
Contributor

@PartiallyUntyped PartiallyUntyped commented Dec 30, 2023

Issue: in #12004, we emit a lint for filter(Option::is_some). If the
parent expression is a .map we don't emit that lint as there exists a
more specialized lint for that.

The ICE introduced in #12004 is a consequence of the assumption that a
parent expression after a filter would be a method call with the filter
call being the receiver. However, it is entirely possible to have a
closure of the form

|| { vec![Some(1), None].into_iter().filter(Option::is_some) }

The previous implementation looked at the parent expression; namely the
closure, and tried to check the parameters by indexing [0] on an empty
list.

This commit is an overhaul of the lint with significantly more FP tests
and checks.

Impl details:

  1. We verify that the filter method we are in is a proper trait method
    to avoid FPs.
  2. We check that the parent expression is not a map by checking whether
    it exists; if is a trait method; and then a method call.
  3. We check that we don't have comments in the span.
  4. We verify that we are in an Iterator of Option and Result.
  5. We check the contents of the filter.
    1. For closures we peel it. If it is not a single expression, we don't
      lint.
    2. For paths, we do a typecheck to avoid FPs for types that impl
      functions with the same names.
    3. For calls, we verify the type, via the path, and that the param of
      the closure is the single argument to the call.
    4. For method calls we verify that the receiver is the parameter of
      the closure. Since we handle single, non-block exprs, the
      parameter can't be shadowed, so no FP.

This commit also adds additional FP tests.

Adding @xFrednet as you've the most context for this as you reviewed it last time.
@rustbot r? @xFrednet

Fixes: #12058

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 30, 2023
@PartiallyUntyped PartiallyUntyped marked this pull request as ready for review December 31, 2023 08:36
@PartiallyUntyped PartiallyUntyped marked this pull request as draft December 31, 2023 10:54
@PartiallyUntyped PartiallyUntyped marked this pull request as ready for review December 31, 2023 15:54
@PartiallyUntyped PartiallyUntyped changed the title Fixed ICE introduced in #12004 Fix ICE introduced in #12004 Jan 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2024

Could not assign reviewer from: xFrednet.
User(s) xFrednet are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

Issue: in #12004, we emit a lint for `filter(Option::is_some)`. If the
parent expression is a `.map` we don't emit that lint as there exists a
more specialized lint for that.

The ICE introduced in #12004 is a consequence of the assumption that a
parent expression after a filter would be a method call with the filter
call being the receiver. However, it is entirely possible to have a
closure of the form

```
|| { vec![Some(1), None].into_iter().filter(Option::is_some) }
```
The previous implementation looked at the parent expression; namely the
closure, and tried to check the parameters by indexing [0] on an empty
list.

This commit is an overhaul of the lint with significantly more FP tests
and checks.

Impl details:

1. We verify that the filter method we are in is a proper trait method
   to avoid FPs.
2. We check that the parent expression is not a map by checking whether
   it exists; if is a trait method; and then a method call.
3. We check that we don't have comments in the span.
4. We verify that we are in an Iterator of Option and Result.
5. We check the contents of the filter.
  1. For closures we peel it. If it is not a single expression, we don't
     lint.
  2. For paths, we do a typecheck to avoid FPs for types that impl
     functions with the same names.
  3. For calls, we verify the type, via the path, and that the param of
     the closure is the single argument to the call.
  4. For method calls we verify that the receiver is the parameter of
     the closure. Since we handle single, non-block exprs, the
     parameter can't be shadowed, so no FP.

This commit also adds additional FP tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index out of bounds: panicked at iter_filter.rs:26:26
3 participants