[case_sensitive_file_extension_comparisons]: Don't trigger on digits-only extensions
#12293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-only extensions
rustbot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Feb 14, 2024
|
Looks good to me, nice work! |
y21
approved these changes
Feb 14, 2024
|
Looks good to me as well. Thanks for the nice fix! @bors r+ |
bors
added a commit
that referenced
this pull request
Feb 14, 2024
[`case_sensitive_file_extension_comparisons`]: Don't trigger on digits-only extensions If we find a file extension check with only digits (`.123`), do not trigger `case_sensitive_file_extension_comparisons`. Fixes #12252 --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`case_sensitive_file_extension_comparisons`]: Don't trigger on digits-only extensions
|
💔 Test failed - checks-action_test |
|
Looks like our macOS runners are still flaky :( bors pls 🥺 |
|
This got me scared for a minute. The logs don't seem to contain any useful information to debug what is happening :( |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we find a file extension check with only digits (
.123), do not triggercase_sensitive_file_extension_comparisons.Fixes #12252
Please write a short comment explaining your change (or "none" for internal only changes)
changelog: [
case_sensitive_file_extension_comparisons]: Don't trigger on digits-only extensions