Skip to content

Remove double expr lint #12401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

MarcusGrass
Copy link
Contributor

Related to #12379.

Previously the code manually checked nested binop exprs in unary exprs, but those were caught anyway by check_expr. Removed that code path, the path is used in the tests.


changelog: [nonminimal_bool] Remove duplicate output on nested Binops in Unary exprs.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 3, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas
Copy link
Member

blyxyas commented Mar 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2024

📌 Commit 8e3ad2e has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 6, 2024

⌛ Testing commit 8e3ad2e with merge a79db2a...

@bors
Copy link
Contributor

bors commented Mar 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing a79db2a to master...

@bors bors merged commit a79db2a into rust-lang:master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants