Skip to content

Conversation

franciscoBSalgueiro
Copy link
Contributor

closes: #11738

Removed the from_expansion guard clause for cast lints, so that these warnings can be generated for internal macros.

changelog: allow cast lints in macros

Removed the `from_expansion` guard clause for cast lints, so that these warnings can be generated for internal macros.
@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 4, 2024
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️
This would change the outcome so that no lints were processed on proc macros. But hey, I don't think that we want to run cast lints on proc macros anyways haha =^w^=

@blyxyas
Copy link
Member

blyxyas commented Apr 4, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2024

📌 Commit ac225a3 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 4, 2024

⌛ Testing commit ac225a3 with merge 08dac85...

@bors
Copy link
Contributor

bors commented Apr 4, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 08dac85 to master...

@bors bors merged commit 08dac85 into rust-lang:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cast-related lint should warn internal macros
4 participants