Threadlocal_initializer_can_be_made_const will not trigger for unreachable initializers #12685
Conversation
rustbot
added
the
S-waiting-on-review
|
I've made a new patch that does a few things: |
…hable initializers
This commit introduces a check to ensure that the lint won't trigger when the initializer is
unreachable, such as:
```
thread_local! {
static STATE: Cell<usize> = panic!();
}
```
This is achieved by looking at the unpeeled initializer expression and ensuring that the parent
macro is not `panic!()`, `todo!()`, `unreachable!()`, `unimplemented!()`.
fixes #12637
changelog: [`threadlocal_initializer_can_be_made_const`] will no longer trigger on `unreachable` macros.
|
@bors r+ |
|
This pattern seems to happen pretty often. |
Threadlocal_initializer_can_be_made_const will not trigger for unreachable initializers
This commit introduces a check to ensure that the lint won't trigger when the initializer is unreachable, such as:
```
thread_local! {
static STATE: Cell<usize> = panic!();
}
```
This is achieved by looking at the unpeeled initializer expression and ensuring that the parent macro is not `panic!()`, `todo!()`, `unreachable!()`, `unimplemented!()`.
fixes #12637
changelog: [`threadlocal_initializer_can_be_made_const`] will no longer trigger on `unreachable` macros.
|
@bors r- |
|
Hmmmm... lemme see where else is this pattern used (meow) |
|
☀️ Try build successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Where else is some kind of function like this used? I've tried to Ctrl+Shift+F but there doesn't seem to exist almost anywhere else (and be extrapolatable) |
|
Off the top of my head; In |
|
Hmmm... If there are at least two others and you're feeling extra-helpful today, yeah it would help! ❤️ |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This commit introduces a check to ensure that the lint won't trigger when the initializer is unreachable, such as:
This is achieved by looking at the unpeeled initializer expression and ensuring that the parent macro is not
panic!(),todo!(),unreachable!(),unimplemented!().fixes #12637
changelog: [
threadlocal_initializer_can_be_made_const] will no longer trigger onunreachablemacros.