Skip to content

[arithmetic_side_effects] Fix #12318 #12692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

[arithmetic_side_effects] Fix #12318 #12692

merged 1 commit into from
Apr 22, 2024

Conversation

c410-f3r
Copy link
Contributor

Fix #12318

changelog: [arithmetic_side_effects]: Consider method calls that correspond to arithmetic symbols

@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 18, 2024
@c410-f3r
Copy link
Contributor Author

ping @Manishearth

@Manishearth
Copy link
Member

@bors r+

oops

@bors
Copy link
Contributor

bors commented Apr 22, 2024

📌 Commit 2a4dae3 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 22, 2024

⌛ Testing commit 2a4dae3 with merge 7fcaa60...

@bors
Copy link
Contributor

bors commented Apr 22, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 7fcaa60 to master...

@bors bors merged commit 7fcaa60 into rust-lang:master Apr 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arithmetic_side_effects not triggered when add_assign used
4 participants