Skip to content

[type_complexity]: Fix duplicate errors #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

UlazkaMateusz
Copy link
Contributor

Relates to #12379

Following message was duplicated:

LL |     fn def_method(&self, p: Vec<Vec<Box<(u32, u32, u32, u32)>>>) {}
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`

error: very complex type used. Consider factoring parts into `type` definitions
  --> tests/ui/type_complexity.rs:55:15

Methods check_trait_item and check_fn were both checking method named def_method.
Now check_trait_item only checks methods without body.


changelog: [type_complexity]: Fix duplicate diagnostics

@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 29, 2024
@xFrednet
Copy link
Member

Looks good to me, nice clean change. Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2024

📌 Commit 71db2d1 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 29, 2024

⌛ Testing commit 71db2d1 with merge 70e74b1...

@bors
Copy link
Contributor

bors commented Apr 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 70e74b1 to master...

@bors bors merged commit 70e74b1 into rust-lang:master Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants