Skip to content

Conversation

lochetti
Copy link
Contributor

@lochetti lochetti commented Jun 6, 2024

This PR is modifying the manual_unwrap_or_default to be applied/linted for Results as well. It is part of the fixes desired by #12618

changelog:[manual_unwrap_or_default]: Lint for Result types.

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 6, 2024
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! @lochetti

@dswij
Copy link
Member

dswij commented Jun 7, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 7, 2024

📌 Commit 478d444 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 7, 2024

⌛ Testing commit 478d444 with merge d9ae936...

@bors
Copy link
Contributor

bors commented Jun 7, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing d9ae936 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants