Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 10, 2024

I'm uncovering bugs while working on #11421. ^^'

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 10, 2024
@y21
Copy link
Member

y21 commented Jul 10, 2024

That's a fun one. It seems like originally (before it regressed) it was let vec = vec![1, 2, 3, 4];, but it doesn't seem like that matters for this lint. (just gonna steal this one since it's pretty trivial. also had to edit in a changelog: line otherwise CI will complain)

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2024

📌 Commit a987c30 has been approved by y21

It is now in the queue for this repository.

@GuillaumeGomez
Copy link
Member Author

Arf, I forgot the changelog line. Sorry about that and thanks for fixing it!

@bors
Copy link
Contributor

bors commented Jul 10, 2024

⌛ Testing commit a987c30 with merge ef3cfaa...

@bors
Copy link
Contributor

bors commented Jul 10, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing ef3cfaa to master...

@bors bors merged commit ef3cfaa into rust-lang:master Jul 10, 2024
@GuillaumeGomez GuillaumeGomez deleted the fix-iter_next_loop.rs branch July 10, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants