Skip to content

fix [excessive_precision] suggestions on floats written in scientific notation #13096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix [excessive_precision] suggestions on floats written in scientific notation #13096

merged 1 commit into from
Jul 16, 2024

Conversation

apoisternex
Copy link
Contributor

fixes #12954

changelog: fix [excessive_precision] suggestions on float literal written in scientific notation

@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 14, 2024
@y21
Copy link
Member

y21 commented Jul 15, 2024

Thanks for the PR! Can you add the code from the linked issue as a test case (in tests/ui/excessive_precision.rs)?

@apoisternex
Copy link
Contributor Author

Thanks for the PR! Can you add the code from the linked issue as a test case (in tests/ui/excessive_precision.rs)?

Added 😄

@y21
Copy link
Member

y21 commented Jul 15, 2024

And could you please also squash the commits?

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease

The following commits are merge commits:

…cientific notation

fixes: #12954

changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 15, 2024
@y21
Copy link
Member

y21 commented Jul 16, 2024

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2024

📌 Commit 489a778 has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 16, 2024

⌛ Testing commit 489a778 with merge 0ee9f44...

@bors
Copy link
Contributor

bors commented Jul 16, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing 0ee9f44 to master...

@bors bors merged commit 0ee9f44 into rust-lang:master Jul 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The excessive_precision linter suggestion causes a compilation error
4 participants