-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix [excessive_precision
] suggestions on floats written in scientific notation
#13096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @y21 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thanks for the PR! Can you add the code from the linked issue as a test case (in tests/ui/excessive_precision.rs)? |
Added 😄 |
And could you please also squash the commits? |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
…cientific notation fixes: #12954 changelog: fix [`excessive_precision`] suggestions on float literal written in scientific notation
Thanks! @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #12954
changelog: fix [
excessive_precision
] suggestions on float literal written in scientific notation