Skip to content

Fix [redundant_slicing] when the slice is behind a mutable reference #13126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

apoisternex
Copy link
Contributor

Fixes #12751

changelog: Fix [redundant_slicing] when the slice is behind a mutable reference and a immutable reference is expected.

Fixes rust-lang#12751

changelog: Fix [`redundant_slicing`] when the slice is behind a mutable reference
@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 19, 2024
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dswij
Copy link
Member

dswij commented Aug 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2024

📌 Commit 58027e2 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 3, 2024

⌛ Testing commit 58027e2 with merge 1aa686b...

@bors
Copy link
Contributor

bors commented Aug 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing 1aa686b to master...

@bors bors merged commit 1aa686b into rust-lang:master Aug 3, 2024
8 checks passed
@apoisternex apoisternex deleted the issue12751 branch August 10, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redundant_slicing suggests change that doesn't compile.
4 participants