Skip to content

Conversation

xFrednet
Copy link
Contributor

This PR makes three changes to lintcheck's job summary:

  • Adds links to the Added, Removed, Changed sections
  • Added the crate name to the warning info
  • Removes empty lines from the rendered output

This is what the new output roughly looks like:

image
image

🖼️ Old Output 🖼️

🖼️ New Output 🖼️

The links for the sections are a bit weird as you have to click on them twice. I believe this is a bug from GH's side. But it works reasonably well :D


changelog: none

r? @Alexendoo

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 20, 2024
@Alexendoo
Copy link
Member

Woah I didn't know you could make your own anchors in GH, that's cool

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2024

📌 Commit 69c3289 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 21, 2024

⌛ Testing commit 69c3289 with merge 7f0ed11...

@bors
Copy link
Contributor

bors commented Jul 21, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 7f0ed11 to master...

@bors bors merged commit 7f0ed11 into rust-lang:master Jul 21, 2024
@xFrednet xFrednet deleted the lintcheck-linkify-summary branch July 21, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants