Skip to content

Fix running compile-test under cargo nextest #13151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

Alexendoo
Copy link
Member

ui_test itself has cargo nextest support which we now use - oli-obk/ui_test#161

It prints ui_test as its test name whereas we printed compile_test, this ended up being treated as a test name filter causing all the tests to be filtered out

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2024
@Jarcho
Copy link
Contributor

Jarcho commented Jul 23, 2024

Nice. @bors r+

@bors
Copy link
Contributor

bors commented Jul 23, 2024

📌 Commit af6d49d has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 23, 2024

⌛ Testing commit af6d49d with merge 615284a...

@bors
Copy link
Contributor

bors commented Jul 23, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing 615284a to master...

@bors bors merged commit 615284a into rust-lang:master Jul 23, 2024
8 checks passed
@Alexendoo Alexendoo deleted the nextest branch July 23, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants