Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Aug 6, 2024

r? @flip1995
changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 6, 2024
@Jarcho Jarcho force-pushed the warnings branch 2 times, most recently from 844a84a to d4ea310 Compare August 6, 2024 14:35
@flip1995
Copy link
Member

flip1995 commented Aug 6, 2024

failures:
    test_no_deps_ignores_path_deps_in_workspaces

Oh, this is a good catch. path_dep should be changed to trigger a Clippy lint, not a rustc lint.

Ah nevermind. But that feature should be registered in the Cargo.toml of the path_dep package.

@flip1995
Copy link
Member

flip1995 commented Aug 6, 2024

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 6, 2024

📌 Commit 4e57b2c has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 6, 2024

⌛ Testing commit 4e57b2c with merge 9d9a0dc...

@bors
Copy link
Contributor

bors commented Aug 6, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 9d9a0dc to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants