Skip to content

Conversation

samueltardieu
Copy link
Member

changelog: [needless_raw_strings, needless_raw_string_hashes]: check format_args!() template as well

Fix #13503

@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2024
@samueltardieu
Copy link
Member Author

It looks like lintcheck detects an ICE in the base as well, which would mean it is not due to this PR, right? Interestingly, I don't seem to be able to reproduce it locally.

@Alexendoo
Copy link
Member

Looks like futures-util 0.3.30 doesn't compile on our nightly

error[E0310]: the parameter type `Fut` may not live long enough
  --> src/stream/futures_unordered/task.rs:81:9
   |
81 |         waker_ref(this)
   |         ^^^^^^^^^^^^^^^
   |         |
   |         the parameter type `Fut` must be valid for the static lifetime...
   |         ...so that the type `Fut` will meet its required lifetime bounds
   |
help: consider adding an explicit lifetime bound
   |
78 | impl<Fut: 'static> Task<Fut> {
   |         +++++++++

You could bump it to 0.3.31, it looks fixed there

@samueltardieu
Copy link
Member Author

Looks like futures-util 0.3.30 doesn't compile on our nightly

I noticed this but was surprised to see it identified as an ICE. I will bump it.

@samueltardieu
Copy link
Member Author

Done, and also submitted separately in #13505

@Alexendoo
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2024

📌 Commit 36c31db has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 9, 2024

⌛ Testing commit 36c31db with merge 1f8f982...

@bors
Copy link
Contributor

bors commented Oct 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 1f8f982 to master...

@bors bors merged commit 1f8f982 into rust-lang:master Oct 9, 2024
8 checks passed
@samueltardieu samueltardieu deleted the needless-raw-strings branch November 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_raw_strings, needless_raw_string_hashes: False negative with macros
4 participants