Skip to content

Conversation

hamirmahal
Copy link
Contributor

Fixes #13613

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2024

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2024
run: cargo generate-lockfile

- name: Cache
uses: Swatinem/rust-cache@v2.7.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest v2 doesn't use a deprecated Node.js version.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Can you revert all the formatting changes, please?

@hamirmahal
Copy link
Contributor Author

You're welcome! I'll take a look at it right now.

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit d63322f has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 28, 2024

⌛ Testing commit d63322f with merge d09d85d...

@bors
Copy link
Contributor

bors commented Oct 28, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d09d85d to master...

@bors bors merged commit d09d85d into rust-lang:master Oct 28, 2024
5 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-a-deprecated-nodejs-version branch October 29, 2024 04:12
@hamirmahal
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy.yml uses a deprecated Node.js version
4 participants