auto-fix slow_vector_initialization in some cases
#13947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
autofix_slowvec
branch
from
844f6fe to
39269aa
Compare
lapla-cogito
commented
Jan 5, 2025
Comment on lines
+211
to
+216
| // If there is no comment in `span_to_replace`, Clippy can automatically fix the code. | ||
| let app = if span_contains_comment(cx.tcx.sess.source_map(), span_to_replace) { | ||
| Applicability::Unspecified | ||
| } else { | ||
| Applicability::MachineApplicable | ||
| }; |
There was a problem hiding this comment.
If the span to be linted contains comments, use Applicability::Unspecified, otherwise use Applicability::MachineApplicable.
|
changelog CI passed |
blyxyas
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
slow_vector_initialization]: auto-fix when appropriateI made a change for
slow_vector_initializationlint suggestion to usevec!with size and remove the unneededresize(or similar one) call in #13912, while only the former one was suggested in the previous implementation. Now, I think this lint can be automatically fixed with no unnecessary code in some cases. I wrote “in some cases” because if there are comments between vector declaration andresize, Clippy shouldn't apply auto-fix because the comment may informational.