new lint: unnecessary_indexing
#14058
Conversation
do not lint after mutable reference is taken check path to local on conditional receiver, check mutable borrow after ref, do not lint on mutable auto borrow fix autoborrow/mutability checks remove unneded `extra_locals` inline if ststements; check locality earlier remove unnecessary impl on IndexCheckResult check for borrows in if block and change inner `Some` based on this
…f condition & lint messages etc.
rustbot
added
the
S-waiting-on-review
| /// Use instead: | ||
| /// ```no_run | ||
| /// let a: &[i32] = &[1]; | ||
| /// if let Some(b) = a.first() { |
There was a problem hiding this comment.
Note that you can generate even simplier expressions:
- If
ais a slice ref, use:if let [b, ..] = a - If
ais an array, use:if let [b, ..] = &a - If
aderefs to a slice, use:if let [b, ..] = &a[..]
There was a problem hiding this comment.
I can add it as an alternate suggestion, which one is more preferable though?
There was a problem hiding this comment.
They're in order of preference. a is the simplest, &a is needed if a is [T] or [T; _], and &a[..] is needed for everything else.
|
☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
added
S-waiting-on-author
|
Ping @Alexendoo from triage. This is still waiting on a review. |
There was a problem hiding this comment.
I think also some of the points in #12464 still apply such as #12464 (comment)
| let receiver = snippet(cx, receiver_span, ".."); | ||
| let mut suggestions: Vec<(Span, String)> = vec![]; | ||
| let mut message = "consider using `if..let` syntax instead of indexing".to_string(); |
There was a problem hiding this comment.
These can be moved into the lint callback
| // span of the receiver for the index operation, only Some in the event the indexing is via a direct primitive | ||
| index_receiver_span: Option<Span>, |
There was a problem hiding this comment.
The Option here can be removed since process_indexing already returns an Option<IndexCheckResult>
|
Ping @J-ZhengLi from triage. Do you plan to return to working on this? |
yes, sorry I'm in a family vacation😃, I'll get back in a few days |
closes: #11858
This is a continuation of #12464 (shout out to @Jacherr for their hard work)
Since they don't have time, I thought I could push this forward by adding another commit on top of it to fix some of the addressed issues.
r? Alexendoo
changelog: add new lint [
unnecessary_indexing]