Fix clippy::version of elidable_lifetime_names to 1.87 #14654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
corneliusroemer
changed the title
This was referenced Apr 19, 2025
The lint becomes part of stable in 1.87, not in 1.84
This comment has been minimized.
This comment has been minimized.
corneliusroemer
commented
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #14653
changelog: [
elidable_lifetime_names]: Fix clippy version that this lint was introduced in.It might be good to have some automation to check that the version is correct.
IIUC the version should be the current nightly version at the time a PR is merged.
If a release happens while a PR is open, the version needs to be bumped - this is easy to forget.