Skip to content

Fix needless_for_each suggests wrongly when closure has no braces #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Fix needless_for_each suggests wrongly when closure has no braces #14735

merged 2 commits into from
May 22, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented May 5, 2025 •
edited by rustbot
Loading

Closes #14734

changelog: [needless_for_each] wrong suggestions when closure has no braces

@rustbot
Copy link
Collaborator

rustbot commented May 5, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 5, 2025
@profetia profetia force-pushed the issue14734 branch 2 times, most recently from a326cfd to 500bc9f Compare May 6, 2025 07:04
blyxyas
blyxyas reviewed May 10, 2025
View reviewed changes
@profetia profetia force-pushed the issue14734 branch 2 times, most recently from e577327 to 32c8371 Compare May 13, 2025 10:27
blyxyas
blyxyas reviewed May 13, 2025
View reviewed changes
blyxyas
blyxyas requested changes May 19, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ Could you squash the first two commits?

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 19, 2025
@profetia
Copy link
Contributor Author

Squashed.

blyxyas
blyxyas approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue May 22, 2025
Merged via the queue into rust-lang:master with commit 5dccb10 May 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing { … } for needless_for_each
3 participants
@profetia @rustbot @blyxyas