Rework module_inception
#14753
Merged
Rework module_inception
#14753
+121
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
Jarcho
force-pushed
the
mod_inception
branch
2 times, most recently
from
cfeac47 to
fa4b49b
Compare
Manishearth
reviewed
May 8, 2025
| name: Symbol, | ||
| name_camel: String, | ||
| is_public: bool, | ||
| in_body_count: u32, |
|
r? clippy |
This comment has been minimized.
This comment has been minimized.
y21
approved these changes
Jun 1, 2025
This comment has been minimized.
This comment has been minimized.
* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting
Jarcho
force-pushed
the
mod_inception
branch
from
b62beeb to
26cf3ee
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_from_proc_macrobefore lintingchangelog: none