Reenable linting on UFCS deref calls
#14808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
clippy_lints/src/dereference.rs
Outdated
Comment on lines
694
to
699
| let mutbl = if tcx.is_diagnostic_item(sym::deref_method, def_id) { | ||
| Mutability::Not | ||
| } else if tcx.trait_of_item(def_id)? == tcx.lang_items().deref_mut_trait()? { | ||
| Some(( | ||
| RefOp::Method { | ||
| mutbl: Mutability::Mut, | ||
| is_ufcs, | ||
| }, | ||
| arg, | ||
| )) | ||
| Mutability::Mut | ||
| } else { | ||
| None | ||
| } | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
This does only one lookup:
let mutbl = match tcx.get_diagnostic_name(def_id)? {
sym::deref_method => Mutability::Not,
sym::deref_mut_method => Mutability::Mut,
_ => return None,
};
Jarcho
force-pushed
the
deref_methods_ufcs
branch
from
10e43fd to
d69df22
Compare
Jarcho
force-pushed
the
deref_methods_ufcs
branch
from
d69df22 to
27acbf2
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was disabled in #10855 due to a broken suggestion. This will only lint if a type is not proveded (e.g.
T::deref).changelog: none